Conversation
# Conflicts: # server/grails-app/services/org/gokb/PackageSourceUpdateService.groovy
mask passwords in admin ui
# Conflicts: # server/build.gradle # server/grails-app/services/org/gokb/PackageSourceUpdateService.groovy
- regard expected and retired titles for tipp-count in wekb-import
There was a problem hiding this comment.
All of the methods in this controller should be restricted to ROLE_CONTRIBUTOR.
There was a problem hiding this comment.
Not really applicable for this class of objects. Don't think we would have any embeds.
There was a problem hiding this comment.
It might be best do do this once for all tests, and then make sure to only do the stop() after the last test.
There was a problem hiding this comment.
Properties should be in camel case, which should then be explicitly mapped to a pascal case column name via mapping, for example ep_url with the prefix for endPoint . The prefix ba is too cryptic here and should be replaced by a more descriptive one.
| resultList*.remove('ba_password') | ||
| resultList*.remove('ba_username') | ||
|
|
||
| if (params['method']) { |
There was a problem hiding this comment.
Filtering after the fact is not permissible, since it may invalidate the pagination info. Custom logic should be added in componentLookupService.restLookup if necessary.
There was a problem hiding this comment.
Mapping configuration for this should be set in the domain class via jsonMapping.ignore.
server/src/integration-test/groovy/org/gokb/UpdatePackageRunFTPSpec.groovy
Outdated
Show resolved
Hide resolved
2 participants
No description provided.